Nj 122 driver license #5045
Open
Nj 122 driver license #5045
+187
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5045-efb03078e667.herokuapp.com/ |
aloverso
approved these changes
Dec 2, 2024
Comment on lines
+1997
to
+2005
| expect(pdf_fields["Drivers License Number Voluntary Instructions page 44"]).to eq "1" | ||
| expect(pdf_fields["Text246"]).to eq "2" | ||
| expect(pdf_fields["Text247"]).to eq "3" | ||
| expect(pdf_fields["Text248"]).to eq "4" | ||
| expect(pdf_fields["Text249"]).to eq "5" | ||
| expect(pdf_fields["Text250"]).to eq "6" | ||
| expect(pdf_fields["Text251"]).to eq "7" | ||
| expect(pdf_fields["Text252"]).to eq "8" | ||
| expect(pdf_fields["Text253"]).to eq "9" |
There was a problem hiding this comment.
[dust] where are these numbers coming from? I don't see them in the setup but maybe it's the default for those factories?
There was a problem hiding this comment.
yep exactly it is the default for a mock state_id
vita-min/spec/factories/state_ids.rb
Line 19 in 0e91274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://github.com/newjersey/affordability-pm/issues/122
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
state_idfeature used by other states as much as possible, which is why this PR doesn't contain any code for XML input or building the formHow to test?
Screenshots (for visual changes)
minimal_720.mov